Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #328, lgtm warning #330

Merged
merged 1 commit into from
Jan 21, 2020
Merged

fix #328, lgtm warning #330

merged 1 commit into from
Jan 21, 2020

Conversation

avan989
Copy link
Contributor

@avan989 avan989 commented Dec 23, 2019

Describe the contribution
fix lgtm warning.

Testing performed
Steps taken to test the contribution:

  1. Build against dummy repo using lgtm.
  2. Verify warning is fixed
  3. Cppcheck.
  4. Verify no warning
  5. Build
  6. Verify still build.

System(s) tested on:

  • Hardware
  • Ubuntu 18.04
  • CFE 6.6

Contributor Info
Anh Van, NASA Goddard.

skliper
skliper requested changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove break; after return since it is unreachable code. Multiple instances.

@skliper skliper added this to the 5.1.0 milestone Dec 30, 2019
@avan989
Copy link
Contributor Author

avan989 commented Jan 8, 2020

updated.

jphickey
jphickey requested changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes noted in previous review comments

@avan989
Copy link
Contributor Author

avan989 commented Jan 8, 2020

updated. Split os-impl-bsd-sockets.c to a separate issue.

@avan989 avan989 mentioned this pull request Jan 8, 2020
Closed
@skliper skliper added the CCB:Approved Indicates code review and approval by community CCB label Jan 21, 2020
@skliper
Copy link
Contributor

skliper commented Jan 21, 2020

CCB 20200115 - Reviewed and approved for IC

@skliper skliper changed the base branch from master to ic-20200121 January 21, 2020 22:32
@skliper skliper merged commit 9379371 into nasa:ic-20200121 Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

@jphickey jphickey jphickey approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.
3 participants
@avan989 @skliper @jphickey